-
Notifications
You must be signed in to change notification settings - Fork 489
add wrapper for telogator2 #7481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
will stay in draft mode until I can add the tool for building reference files |
d52f7fa to
cc172e9
Compare
tools/telogator2/telogator2.xml
Outdated
| <option value="median">Median</option> | ||
| <option value="max">Maximum</option> | ||
| </param> | ||
| <param name="downsample" argument="-d" type="integer" optional="true" label="Downsample telomere reads" help="Downsample to N telomere reads (optional)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that we need value="" for optional parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
| </section> | ||
|
|
||
| <section name="reference_opts" title="Reference Options" expanded="false"> | ||
| <param name="custom_reference" argument="-t" type="data" format="fasta" optional="true" label="Custom reference FASTA" help="Optional custom telogator reference FASTA file. If not provided, built-in human T2T reference will be used."/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
human T2T
Is this in the container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! A default human T2T (also maze and mouse) reference is included. I'm also adding the reference building tool, should be in bioconda this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it maybe be wise to require the user to provide a reference and not rely on the once included? Right now you loose a bit of the data tracabillity since the included references are include in the source package, and it's not super clear which reference version that have been used to build the included ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reproducibility is given IMO. Only transparency is questionable. Maybe also ask upstream?
|
|
||
| <section name="reference_opts" title="Reference Options" expanded="false"> | ||
| <param name="custom_reference" argument="-t" type="data" format="fasta" optional="true" label="Custom reference FASTA" help="Optional custom telogator reference FASTA file. If not provided, built-in human T2T reference will be used."/> | ||
| <param name="kmer_file" argument="-k" type="data" format="txt" optional="true" label="Telomere kmers file" help="Optional telomere kmers file (required for non-human organisms like mouse or maize)"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any more info in this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Information about the kmer file is currently very sparse on in the repo. I have asked them to add more information about it.
tools/telogator2/telogator2.xml
Outdated
| <param argument="--filt-nontel" type="integer" value="100" min="0" label="Maximum terminating non-telomere" help="Maximum terminating non-telomere length in bp"/> | ||
| <param argument="--filt-sub" type="integer" value="1000" min="0" label="Minimum terminating subtelomere" help="Minimum terminating subtelomere length in bp"/> | ||
| <param argument="--collapse-hom" type="integer" value="1000" min="0" label="Collapse homologous alleles" help="Merge alleles within this distance in bp"/> | ||
| <param argument="--fast-aln" type="boolean" truevalue="true" falsevalue="false" checked="false" label="Use fast alignment" help="Use faster but less accurate pairwise alignment"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use truevalue="--fast-aln" falsevalue="" then you can just $fast_aln in the command section and don't need the if statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
FOR CONTRIBUTOR: